Minor fixes #4
Merged
Minor fixes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any suggestion as to how to motivate more people to review? My crypto code isn't likely to see actual production use for some time yet, so while I share your concern for review, this is not urgent on that front. Also, it looks like if RFC 495 (rust-lang/rust#23121) is closed, it will be possible to implement array_ref! without unsafe, which would be lovely. But I'm not clear on how likely that is to happen "soon". |
|
P.S. Thanks so much for the review and the patches! |
|
You can ask for review on the user forum. Btw, issue #1 can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These macros look good to me, but could use even more people reviewing since you put them to use in crypto code.